Skip to content

Add test coverage for SpecialKeyRangeAsyncImpl::getRange (snowflake-7.1) #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-clin merged 1 commit into from
Aug 9, 2022
Merged

Add test coverage for SpecialKeyRangeAsyncImpl::getRange (snowflake-7.1) #7779

sfc-gh-clin merged 1 commit into from
Aug 9, 2022

Conversation

@sfc-gh-clin
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin commented Aug 3, 2022

Cherry-pick #7671

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-clin
Add test coverage for SpecialKeyRangeAsyncImpl::getRange (apple#7671)
b35f63a 
* Add getRange test coverage for SpecialKeyRangeAsyncImpl

* Fix the bug in SpecialKeyRangeAsyncImpl found by the test

* Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code

* Fix file format

* Initialize SpecialKeyRangeAsyncImpl cache with correct end key

* Add release notes

* Revert "Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code"

This reverts commit fdd298f.
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b35f63a
  • Duration 0:38:46
  • Result: ❌ FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/foundationdb-base:${FDB_VERSION}-${COMMIT_SHA}-debug --file Dockerfile.eks --target foundationdb-base .. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 3, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 3, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b35f63a
  • Duration 0:49:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin self-assigned this Aug 3, 2022
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: b35f63a
  • Duration 0:32:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin merged commit f6f6b08 into apple:snowflake/release-7.1 Aug 9, 2022
@sfc-gh-clin sfc-gh-clin deleted the cherry-pick-7671-sf-7.1 branch August 9, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-xwang sfc-gh-xwang sfc-gh-xwang approved these changes

@sfc-gh-ljoswiak sfc-gh-ljoswiak sfc-gh-ljoswiak approved these changes

@sfc-gh-anoyes sfc-gh-anoyes Awaiting requested review from sfc-gh-anoyes

Assignees

@sfc-gh-clin sfc-gh-clin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-clin @foundationdb-ci @fdb-windows-ci @sfc-gh-xwang @sfc-gh-ljoswiak