Add test coverage for SpecialKeyRangeAsyncImpl::getRange(release-7.1) #7778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add extra validation to special key space reads in simulation * Fix bugs turned up by validating subrange reads * Change to validateSpecialSubrangeRead It is in general not safe to expect that a read from the special key space returns the same results if performed again, since the transaction may be being modified concurrently. * Add comment * Add comment
* Add getRange test coverage for SpecialKeyRangeAsyncImpl * Fix the bug in SpecialKeyRangeAsyncImpl found by the test * Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code * Fix file format * Initialize SpecialKeyRangeAsyncImpl cache with correct end key * Add release notes * Revert "Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code" This reverts commit fdd298f.
sfc-gh-clin
requested review from
jzhou77,
sfc-gh-anoyes,
sfc-gh-ljoswiak and
sfc-gh-xwang
Collaborator
Doxense CI Report for Windows 10
|
sfc-gh-anoyes
approved these changes
Aug 3, 2022
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
sfc-gh-ljoswiak
approved these changes
Aug 3, 2022
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
jzhou77
approved these changes
Aug 4, 2022
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
1inker
pushed a commit
to owtech/foundationdb
that referenced
this pull request
Aug 17, 2022
…apple#7778) * Validate subrange reads in simulation (apple#7597) * Add extra validation to special key space reads in simulation * Fix bugs turned up by validating subrange reads * Change to validateSpecialSubrangeRead It is in general not safe to expect that a read from the special key space returns the same results if performed again, since the transaction may be being modified concurrently. * Add comment * Add comment * Add test coverage for SpecialKeyRangeAsyncImpl::getRange (apple#7671) * Add getRange test coverage for SpecialKeyRangeAsyncImpl * Fix the bug in SpecialKeyRangeAsyncImpl found by the test * Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code * Fix file format * Initialize SpecialKeyRangeAsyncImpl cache with correct end key * Add release notes * Revert "Refactor ConflictingKeysImpl::getRange to use containedRanges to simplify the code" This reverts commit fdd298f. Co-authored-by: Andrew Noyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #7671
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)