Skip to content

Prefer IPv6 in hostname resolving (release-7.1). #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RenxuanW merged 1 commit into from
Aug 1, 2022
Merged

Prefer IPv6 in hostname resolving (release-7.1). #7750

RenxuanW merged 1 commit into from
Aug 1, 2022

Conversation

@RenxuanW
Copy link
Contributor

@RenxuanW RenxuanW commented Aug 1, 2022

Backporting #7733.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

flowguru
flowguru previously approved these changes Aug 1, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 16402db
  • Duration 0:05:18
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 1, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 16402db
  • Duration 0:06:43
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 16402db
  • Duration 0:06:45
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

@RenxuanW RenxuanW requested a review from flowguru August 1, 2022 20:06
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 1, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 464d03e
  • Duration 1:10:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 464d03e
  • Duration 1:33:11
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 1, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 464d03e
  • Duration 0:33:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@RenxuanW RenxuanW merged commit 1ce8b6e into apple:release-7.1 Aug 1, 2022
@RenxuanW RenxuanW deleted the hostname-7.1 branch August 1, 2022 22:20
1inker pushed a commit to owtech/foundationdb that referenced this pull request Aug 17, 2022
@RenxuanW @1inker
Prefer IPv6 in hostname resolving. (apple#7750)
8d9bf2a
@larshagencognite larshagencognite mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brownleej brownleej Awaiting requested review from brownleej

@jzhou77 jzhou77 Awaiting requested review from jzhou77

2 more reviewers

@halfprice halfprice halfprice approved these changes

@flowguru flowguru flowguru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RenxuanW @foundationdb-ci @fdb-windows-ci @halfprice @flowguru