Skip to content

Conversation

@RenxuanW
Copy link
Contributor

20220729-030411-renxuan-7e4281256c2c161d compressed=True data_size=35236790 fail_fast=10 max_runs=100000 priority=100 sanity=False submitted=20220729-030411 timeout=5400 username=renxuan

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@RenxuanW RenxuanW requested review from brownleej and halfprice July 29, 2022 03:06
@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 8cd9098
  • Duration 0:49:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8cd9098
  • Duration 1:10:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8cd9098
  • Duration 1:44:05
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 316ea60
  • Duration 1:50:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 316ea60
  • Duration 1:04:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

halfprice
halfprice previously approved these changes Aug 1, 2022
halfprice
halfprice previously approved these changes Aug 1, 2022
@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@apple apple deleted a comment from foundationdb-ci Aug 1, 2022
@apple apple deleted a comment from foundationdb-ci Aug 1, 2022
@apple apple deleted a comment from foundationdb-ci Aug 1, 2022
@apple apple deleted a comment from foundationdb-ci Aug 1, 2022
@RenxuanW RenxuanW requested a review from halfprice August 1, 2022 17:54
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 22c931d
  • Duration 0:10:00
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 22c931d74a6610af26781462828eb8b25cd7d07d
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 22c931d
  • Duration 0:10:21
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 22c931d74a6610af26781462828eb8b25cd7d07d
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 22c931d
  • Duration 0:11:22
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 22c931d74a6610af26781462828eb8b25cd7d07d
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4a0bea2
  • Duration 1:04:52
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4a0bea2
  • Duration 1:29:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@RenxuanW RenxuanW merged commit 51b92d5 into apple:main Aug 1, 2022
@RenxuanW RenxuanW deleted the hostname-backup branch August 1, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants