Skip to content

Add g_traceBatch for prefetch query #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flowguru merged 2 commits into from
Jul 29, 2022
Merged

Add g_traceBatch for prefetch query #7730

flowguru merged 2 commits into from
Jul 29, 2022

Conversation

@flowguru
Copy link
Contributor

@flowguru flowguru commented Jul 28, 2022 •
edited
Loading

joshua 20220728-220401-haofu-4308c580378f2c24

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@flowguru flowguru requested a review from jzhou77 July 28, 2022 22:03
jzhou77
jzhou77 requested changes Jul 28, 2022
View reviewed changes
fdbserver/storageserver.actor.cpp
Comment on lines +4228 to +4230
if (pOriginalReq->debugID.present())
g_traceBatch.addEvent(
"TransactionDebug", pOriginalReq->debugID.get().first(), "storageserver.mapKeyValues.AfterBatch");
Copy link
Contributor

@jzhou77 jzhou77 Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be after wait(waitForAll(subqueries));.

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 28, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a42b2e0
  • Duration 0:11:17
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version a42b2e09addd699c521264b814052ec7c71cd388
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a42b2e0
  • Duration 0:12:47
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version a42b2e09addd699c521264b814052ec7c71cd388
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 28, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 9badec7
  • Duration 1:16:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 9badec7
  • Duration 1:37:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 19d97ce
  • Duration 1:01:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 29, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 19d97ce
  • Duration 1:32:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@flowguru flowguru merged commit 62bee7a into apple:main Jul 29, 2022
flowguru added a commit to flowguru/foundationdb that referenced this pull request Jul 29, 2022
@flowguru
Add g_traceBatch for prefetch query (apple#7730)
6a6306c
@flowguru flowguru mentioned this pull request Jul 29, 2022
Merged
5 tasks
flowguru added a commit that referenced this pull request Jul 29, 2022
@flowguru
Add g_traceBatch for prefetch query (#7730) (#7732)
8bfbc27
1inker pushed a commit to owtech/foundationdb that referenced this pull request Aug 17, 2022
@flowguru @1inker
Add g_traceBatch for prefetch query (apple#7730) (apple#7732)
4cda9ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flowguru @fdb-windows-ci @foundationdb-ci @jzhou77