Skip to content

Validate subrange reads in simulation (#7597) (release-7.1) #7720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-clin merged 2 commits into from
Jul 28, 2022
Merged

Validate subrange reads in simulation (#7597) (release-7.1) #7720

sfc-gh-clin merged 2 commits into from
Jul 28, 2022

Conversation

@sfc-gh-clin
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin commented Jul 27, 2022 •
edited
Loading

Cherry-pick bug fix #7597

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-anoyes @sfc-gh-clin
Validate subrange reads in simulation (apple#7597)
54519e4 
* Add extra validation to special key space reads in simulation

* Fix bugs turned up by validating subrange reads

* Change to validateSpecialSubrangeRead

It is in general not safe to expect that a read from the special key
space returns the same results if performed again, since the
transaction may be being modified concurrently.

* Add comment

* Add comment
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 27, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 27, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 54519e4
  • Duration 0:54:55
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests compile. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 27, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 54519e4
  • Duration 1:03:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 27, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 27, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: aba60a7
  • Duration 0:53:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 27, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: aba60a7
  • Duration 0:54:47
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests compile. Reason: exit status 2
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin changed the title Validate subrange reads in simulation (#7597) Validate subrange reads in simulation (#7597) (release-7.1) Jul 28, 2022
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: aba60a7
  • Duration 0:35:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin merged commit 1df82c5 into apple:release-7.1 Jul 28, 2022
@sfc-gh-clin sfc-gh-clin deleted the cherry-pick-7597 branch July 28, 2022 17:46
1inker pushed a commit to owtech/foundationdb that referenced this pull request Aug 17, 2022
@sfc-gh-clin @sfc-gh-anoyes @1inker
Validate subrange reads in simulation (apple#7597) (apple#7720)
8a2a500 
* Add extra validation to special key space reads in simulation

* Fix bugs turned up by validating subrange reads

* Change to validateSpecialSubrangeRead

It is in general not safe to expect that a read from the special key
space returns the same results if performed again, since the
transaction may be being modified concurrently.

* Add comment

* Add comment

Co-authored-by: Andrew Noyes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

@sfc-gh-anoyes sfc-gh-anoyes sfc-gh-anoyes approved these changes

@sfc-gh-abeamon sfc-gh-abeamon Awaiting requested review from sfc-gh-abeamon

@sfc-gh-ljoswiak sfc-gh-ljoswiak Awaiting requested review from sfc-gh-ljoswiak

@sfc-gh-mdvorsky sfc-gh-mdvorsky Awaiting requested review from sfc-gh-mdvorsky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-clin @fdb-windows-ci @foundationdb-ci @jzhou77 @sfc-gh-anoyes