Fix a crash bug during CC shutdown process #7705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actor_cancel should be thrown, otherwise the rest code can access invalid memory.
5 tasks
Collaborator
Doxense CI Report for Windows 10
|
sfc-gh-etschannen
approved these changes
Jul 26, 2022
halfprice
approved these changes
Jul 26, 2022
Contributor
halfprice
left a comment
halfprice
left a comment
There was a problem hiding this comment.
Won't that all wait(tr.onError(e)); have this issue?
Contributor
Result of foundationdb-pr-macos on macOS BigSur 11.5.2
|
Contributor
NVM. This is inside a try catch block... |
Contributor
Result of foundationdb-pr on Linux CentOS 7
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
sfc-gh-satherton
added a commit
to sfc-gh-satherton/foundationdb
that referenced
this pull request
Jul 26, 2022
… snowflake/release-7.1)
Merged
5 tasks
jzhou77
added a commit
that referenced
this pull request
Jul 26, 2022
…ase-7.1 Fix a crash bug during CC shutdown process (Cherry-pick #7705 to snowflake/release-7.1)
sfc-gh-nwijetunga
added a commit
to sfc-gh-nwijetunga/foundationdb
that referenced
this pull request
Jul 27, 2022
… nim/tenant-encryption-property * 'main' of github.com:sfc-gh-nwijetunga/foundationdb: (42 commits) Get ShardedRocks ready for simulation test. (apple#7679) fixing specific unit test formatting addressing review comments Fix incorrect deserialization of FdbClientLogEvents::Event (apple#7707) Fix a crash bug during CC shutdown process (apple#7705) addressing review comments remove runAfter Add comments explaining the use of the TransactionState tenant() and hasTenant() functions Make sure resumeFromDataMoves() starts after resumeFromShards(). Fix: during recovery, it was possible for tenant operations to briefly fail because the tenant mode is not known formatting Fixed granule purging bug and improved debugging for purging making purge failures fail test cleanup and polish Bug fix and cleanup First version of key-sorted delta files Added full granule read unit test Completed delta format unit test delta file test and delta generation ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actor_cancel should be thrown, otherwise the rest code can access invalid
memory.
100k Status tests 20220726-182507-jzhou-0849bcdb1315c2cf
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)