Skip to content

cherry pick 7653 - Track when version not found in version vector. #7666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 7 commits into from
Aug 25, 2022
Merged

cherry pick 7653 - Track when version not found in version vector. #7666

jzhou77 merged 7 commits into from
Aug 25, 2022

Conversation

@dlambrig
Copy link
Contributor

@dlambrig dlambrig commented Jul 22, 2022 •
edited
Loading

Cherry pick pr #7653

Add new counter to track when the commit version for an SS is not taken from the version vector. When version vector is enabled there may be a performance hit in that situation. Performance diagnosis is harder without it. The counter should normally be 0.

Joshua:
20220729-005942-henrylambright-0ab2bd109c3dd379

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@dlambrig dlambrig requested review from jzhou77 and sbodagala July 22, 2022 15:03
@dlambrig dlambrig marked this pull request as ready for review July 22, 2022 15:03
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 22, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 22, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 558c5e4
  • Duration 0:45:17
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

sbodagala
sbodagala previously approved these changes Jul 22, 2022
View reviewed changes
jzhou77
jzhou77 previously approved these changes Jul 22, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 22, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 558c5e4
  • Duration 3:34:11
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

@dlambrig dlambrig dismissed stale reviews from jzhou77 and sbodagala via ea95420 July 22, 2022 18:47
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 22, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 22, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: ea95420
  • Duration 0:52:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@dlambrig
Copy link
Contributor Author

dlambrig commented Jul 22, 2022

looks like there is a bug in the downgrade test. Moving to draft state until we fix it.

@dlambrig dlambrig marked this pull request as draft July 22, 2022 20:08
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 22, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ea95420
  • Duration 4:17:07
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@dlambrig
Copy link
Contributor Author

dlambrig commented Jul 29, 2022

looks like there is a bug in the downgrade test. Moving to draft state until we fix it.

porting the fix to this from main branch.

@dlambrig dlambrig marked this pull request as ready for review July 29, 2022 01:18
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 29, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 29, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b4ba9ae
  • Duration 1:09:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 29, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a62282a
  • Duration 1:11:16
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 29, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b4ba9ae
  • Duration 1:26:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 29, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a62282a
  • Duration 1:27:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 7, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 7, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: fcad3b0
  • Duration 0:34:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 7, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: fcad3b0
  • Duration 0:57:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 7, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: fcad3b0
  • Duration 1:18:47
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@dlambrig dlambrig requested a review from sbodagala August 7, 2022 15:22
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 19, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 19, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c5fa155
  • Duration 1:52:58
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 19, 2022

Doxense CI Report for Windows 10

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 24, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@jzhou77 jzhou77 merged commit 167e1e6 into release-7.1 Aug 25, 2022
@dlambrig dlambrig deleted the cherry7653 branch August 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

@sbodagala sbodagala sbodagala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dlambrig @fdb-windows-ci @foundationdb-ci @jzhou77 @sbodagala