Skip to content

Conversation

@dlambrig
Copy link
Contributor

@dlambrig dlambrig commented Jul 19, 2022

Cherry pick PR #7613.

getKeyLocation_internal did not update the SSID->Tag cache when receiving results from the proxy's GetKeyServerLocationsRequest interface. This can result in ssidTagMapping not having information to populate the version vector, in turn resulting in the latest commit version used to fetch data from the SS. This caused waitForVersion to be entered, which can delay responses up to BLOCKING_PEEK_TIMEOUT (currently .4) seconds. If a specific workload from a client is being run this can be indefinite.

Tested running mako and verifying read latency fell back to baseline (non vv) levels.

20220719-152356-henrylambright-1d7ef76da4e02f1d

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: b830c75
  • Duration 0:36:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b830c75
  • Duration 0:59:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@dlambrig dlambrig marked this pull request as ready for review July 19, 2022 16:54
@dlambrig dlambrig merged commit 7f9ee8c into release-7.1 Jul 19, 2022
@dlambrig dlambrig deleted the cherry7613 branch July 19, 2022 16:54
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b830c75
  • Duration 2:18:14
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

1inker pushed a commit to owtech/foundationdb that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants