Skip to content

Fix processDiskReadSeconds and processDiskWriteSeconds (release-7.1). #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RenxuanW merged 1 commit into from
Jul 18, 2022
Merged

Fix processDiskReadSeconds and processDiskWriteSeconds (release-7.1). #7609

RenxuanW merged 1 commit into from
Jul 18, 2022

Conversation

@RenxuanW
Copy link
Contributor

@RenxuanW RenxuanW commented Jul 18, 2022

PR on main: #7608.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 18, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 18, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: dc2534c
  • Duration 0:35:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 18, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: dc2534c
  • Duration 0:50:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 18, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: dc2534c
  • Duration 0:59:47
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 self-requested a review July 18, 2022 20:22
@jzhou77 jzhou77 self-assigned this Jul 18, 2022
@RenxuanW RenxuanW merged commit e98b32f into apple:release-7.1 Jul 18, 2022
@RenxuanW RenxuanW deleted the 7.1-cp branch July 18, 2022 20:47
1inker pushed a commit to owtech/foundationdb that referenced this pull request Aug 17, 2022
@RenxuanW @1inker
Fix processDiskReadSeconds and processDiskWriteSeconds. (apple#7609)
2838fb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnamasivayam bnamasivayam bnamasivayam approved these changes

@jzhou77 jzhou77 Awaiting requested review from jzhou77

+1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jzhou77 jzhou77

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RenxuanW @fdb-windows-ci @foundationdb-ci @halfprice @bnamasivayam @jzhou77