Skip to content

Changing hasIncompleteVersionstamp to use iteration rather than stream processing #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scottfines wants to merge 1 commit into from
Closed

Changing hasIncompleteVersionstamp to use iteration rather than stream processing #7543

scottfines wants to merge 1 commit into from

Conversation

@scottfines
Copy link
Contributor

@scottfines scottfines commented Jul 7, 2022

TupleUtil.hasIncompleteVersionstamp() uses stream processing, which can result in some additional copies and object creations. This switches over to an iteration loop which should only create an extra iterator() object.

@scottfines scottfines force-pushed the iterate_incomplete_versionstamp branch from 5209a96 to e8c6369 Compare July 7, 2022 20:52
@scottfines scottfines marked this pull request as ready for review July 7, 2022 20:53
@scottfines scottfines requested a review from sfc-gh-anoyes July 7, 2022 20:53
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 5209a96
  • Duration 0:09:48
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 5209a96e34266e6c4d076ca2dfa797ee86652b31
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 5209a96
  • Duration 0:10:50
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 5209a96e34266e6c4d076ca2dfa797ee86652b31
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 7, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: e8c6369
  • Duration 0:28:29
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: e8c6369
  • Duration 0:29:10
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)

@scottfines scottfines force-pushed the iterate_incomplete_versionstamp branch from e8c6369 to 350804d Compare July 8, 2022 13:56
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 8, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 8, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 350804d
  • Duration 0:41:24
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 8, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 350804d
  • Duration 0:45:14
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}" .. Reason: exit status 1
  • Build Logs (available for 30 days)

@jleach4
Copy link
Contributor

jleach4 commented Jul 8, 2022

Will re-open.

@jleach4 jleach4 closed this Jul 8, 2022
jleach4 added a commit to jleach4/foundationdb that referenced this pull request Jul 8, 2022
@jleach4
Changing hasIncompleteVersionstamp to use iteration rather than strea…
7bf9bc9 
…m processing apple#7543
jleach4 added a commit to jleach4/foundationdb that referenced this pull request Jul 8, 2022
@jleach4
Changing hasIncompleteVersionstamp to use iteration rather than strea…
afa1120 
…m processing apple#7543
jzhou77 added a commit that referenced this pull request Jul 9, 2022
@jzhou77
Merge pull request #7552 from jleach4/7543
3473394 
Changing hasIncompleteVersionstamp to use iteration rather than stream processing #7543
jzhou77 pushed a commit to jzhou77/foundationdb that referenced this pull request Jul 9, 2022
@jleach4 @jzhou77
Changing hasIncompleteVersionstamp to use iteration rather than strea…
f40b947 
…m processing apple#7543
jzhou77 pushed a commit that referenced this pull request Jul 9, 2022
@jleach4 @jzhou77
Changing hasIncompleteVersionstamp to use iteration rather than strea…
4c7890a 
…m processing #7543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-anoyes sfc-gh-anoyes Awaiting requested review from sfc-gh-anoyes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scottfines @foundationdb-ci @fdb-windows-ci @jleach4