Skip to content

Add StorageEngine type to StorageMetrics trace events #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-satherton merged 2 commits into from
Jul 7, 2022
Merged

Add StorageEngine type to StorageMetrics trace events #7534

sfc-gh-satherton merged 2 commits into from
Jul 7, 2022

Conversation

@sfc-gh-satherton
Copy link
Collaborator

@sfc-gh-satherton sfc-gh-satherton commented Jul 7, 2022 •
edited
Loading

Add StorageEngine type to StorageMetrics trace events.
Also hardcoded storage engine types as they must not change.

This will also be cherry picked to the 7.1 branches.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jul 7, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 03df62e
  • Duration 0:40:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 03df62e
  • Duration 0:41:44
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION} .. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 7, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 03df62e
  • Duration 0:58:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-satherton sfc-gh-satherton merged commit e63cb43 into apple:main Jul 7, 2022
sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Jul 7, 2022
@sfc-gh-satherton
Add StorageEngine type to StorageMetrics trace events (cherry-pick ap…
4498b94 
…ple#7534)
sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Jul 7, 2022
@sfc-gh-satherton
Add StorageEngine type to StorageMetrics trace events (cherry-pick ap…
d7e960d 
…ple#7534)
This was referenced Jul 7, 2022
Merged
Merged
jzhou77 pushed a commit that referenced this pull request Jul 9, 2022
@sfc-gh-satherton @jzhou77
Add StorageEngine type to StorageMetrics trace events (cherry-pick #7534
a8d0717 
)
jzhou77 added a commit that referenced this pull request Jul 13, 2022
@jzhou77
Merge pull request #7545 from sfc-gh-satherton/storage-type-improveme…
999097e 
…nts-sfc-7.1

Add StorageEngine type to StorageMetrics trace events (Cherry-pick #7534 to snowflake/release-7.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

@neethuhaneesha neethuhaneesha Awaiting requested review from neethuhaneesha

@sfc-gh-gmuppana sfc-gh-gmuppana Awaiting requested review from sfc-gh-gmuppana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-satherton @fdb-windows-ci @foundationdb-ci @jzhou77