Skip to content

Conversation

@dlambrig
Copy link
Contributor

When version vector was developed a problem was misdiagnosed in PR 5949. It was thought that in UNICAST mode, version vector recovery did not work with cursors built out of tLogs in non-local data centers, when actually the issue encountered at that time was the one described in PR 7405.

Fixes
-r simulation --knob_txs_popped_max_delay=4 --logsize=4096MiB -f ./src/foundationdb/tests/fast/KillRegionCycle.toml -b on -s 715312789

100K successful runs of KillRegionCycle.toml with vv enabled
20220629-185214-henrylambright-d6f7de4a60eab720

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@dlambrig dlambrig requested a review from jzhou77 June 30, 2022 17:20
@dlambrig dlambrig marked this pull request as ready for review June 30, 2022 17:22
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: e91cdf9
  • Duration 0:36:46
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION} .. Reason: exit status 2
  • Build Logs (available for 30 days)

@dlambrig dlambrig requested a review from sbodagala June 30, 2022 18:17
@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: e91cdf9
  • Duration 1:11:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: ee4d3ef
  • Duration 0:33:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ee4d3ef
  • Duration 0:37:18
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION} .. Reason: exit status 2
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: ee4d3ef
  • Duration 0:54:39
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@dlambrig dlambrig merged commit 690c302 into release-7.1 Jul 1, 2022
@dlambrig dlambrig deleted the cherry7499 branch July 1, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants