Ss shard management #7340

liquid-helium · 2022-06-08T00:01:01Z

Introduced the concepts of physical shard to storage server.

Each shard in SS is assigned a UID, the UID is determined by DD;
StorageServerShard is introduced to represent a continuous keyrange in SS, it is persisted locally in persistStorageServerShardKeys special keyrange at each SS. The new metadata is a super set of the current persistShardAssignedKeys and persistShardAvailableKeys. Currently, all these three special keyranges are written, and cross-validated. In the future, we can deprecate persistShardAssignedKeys and persistShardAvailableKeys in shardAware mode.
Introduced changeServerKeysWithPhysicalShards() to manage shard assignments, i.e., response to the shard assignment private mutations.
Implemented shard management workflow, via the IKeyValueStore shard management APIs.

Test: Added PhysicalShardMove.actor.cpp to validate SS shard awareness.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

fdb-windows-ci · 2022-06-08T00:02:33Z

Doxense CI Report for Windows 10

Commit ID: 7378308
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-08T00:06:13Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 7378308
Duration 0:05:04
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-08T00:07:36Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 7378308
Duration 0:06:27
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-08T21:59:26Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: ba0210a
Duration 0:05:08
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-08T22:00:45Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: ba0210a
Duration 0:06:28
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)

fdb-windows-ci · 2022-06-08T22:16:46Z

Doxense CI Report for Windows 10

Commit ID: ba0210a
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-08T22:33:37Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: ba0210a
Duration 0:39:21
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-10T21:12:31Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 77a1870
Duration 0:24:04
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-10T21:12:34Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 77a1870
Duration 0:24:11
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-10T21:17:16Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 77a1870
Duration 0:28:00
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

fdb-windows-ci · 2022-06-10T21:17:33Z

Doxense CI Report for Windows 10

Commit ID: 77a1870
Result: ❌ FAILED
Build Logs (available for 30 days)

fdb-windows-ci · 2022-06-10T22:10:44Z

Doxense CI Report for Windows 10

Commit ID: 9220cb9
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-10T22:18:55Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 9220cb9
Duration 0:26:51
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-10T22:32:40Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 9220cb9
Duration 0:40:32
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Logs (available for 30 days)

fdb-windows-ci · 2022-06-11T01:49:26Z

Doxense CI Report for Windows 10

Commit ID: 445c533
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T01:59:37Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 445c533
Duration 0:28:11
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T02:10:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 9220cb9
Duration 4:18:42
Result: ❌ FAILED
Error: Build has timed out.
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T02:33:12Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 445c533
Duration 1:01:44
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T05:48:37Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 445c533
Duration 4:17:09
Result: ❌ FAILED
Error: Build has timed out.
Build Logs (available for 30 days)

fdb-windows-ci · 2022-06-11T21:47:15Z

Doxense CI Report for Windows 10

Commit ID: 120742a
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T21:57:25Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 120742a
Duration 0:28:04
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-11T22:30:53Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 120742a
Duration 1:01:31
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-12T01:46:32Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 120742a
Duration 4:17:17
Result: ❌ FAILED
Error: Build has timed out.
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-15T18:36:47Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 5359633
Duration 0:57:21
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-15T18:40:29Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 25e89f9
Duration 0:29:39
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-15T19:16:14Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 934e740
Duration 0:29:35
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-06-15T19:29:44Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 25e89f9
Duration 1:18:58
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T04:09:21Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 6386be2
Duration 0:05:37
Result: ❌ FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T04:10:45Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 3cc4e7b
Duration 0:09:46
Result: ❌ FAILED
Error: reference not found for primary source and source version 3cc4e7b2f178878d555b170478572d45757d575f
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T04:10:59Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: 3cc4e7b
Duration 0:10:03
Result: ❌ FAILED
Error: reference not found for primary source and source version 3cc4e7b2f178878d555b170478572d45757d575f
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T04:11:08Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 3cc4e7b
Duration 0:10:11
Result: ❌ FAILED
Error: reference not found for primary source and source version 3cc4e7b2f178878d555b170478572d45757d575f
Build Logs (available for 30 days)

fdb-windows-ci · 2022-07-18T04:23:14Z

Doxense CI Report for Windows 10

Commit ID: 6386be2
Result: ❌ FAILED
Build Logs (available for 30 days)

fdb-windows-ci · 2022-07-18T16:24:12Z

Doxense CI Report for Windows 10

Commit ID: b19a849
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T16:43:08Z

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Commit ID: b19a849
Duration 0:35:22
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T17:15:51Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: b19a849
Duration 1:07:59
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T17:18:11Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: b19a849
Duration 1:10:20
Result: ❌ FAILED
Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
Build Logs (available for 30 days)

fdb-windows-ci · 2022-07-18T18:19:38Z

Doxense CI Report for Windows 10

Commit ID: 6cb416c
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T18:39:49Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 6cb416c
Duration 1:14:00
Result: ❌ FAILED
Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-18T18:51:09Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 6cb416c
Duration 1:25:19
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

fdbclient/include/fdbclient/StorageServerShard.h

fdbserver/storageserver.actor.cpp

jzhou77 · 2022-07-19T17:41:31Z

fdbserver/storageserver.actor.cpp

+		wait(yield());
+	}
+
+	TraceEvent(SevVerbose, "StorageServerRestoreShardsCoalesce", data->thisServerID).detail("Version", version);


add ".log()" to preserve the order of events?

This should already be logged immediately because it is an anonymous trace event. I believe .log should really only be added if you have a named trace event that doesn't have a narrowly scoped lifetime and you want to log it immediately.

Keep it as for now.

@sfc-gh-ajbeamon , how is this "an anonymous trace event"? This event has an event name.

Does A.J. Beamon refer to the fact that the TraceEvent object is anonymous? It will be destructed right away.

fdbserver/storageserver.actor.cpp

fdb-windows-ci · 2022-07-20T21:59:55Z

Doxense CI Report for Windows 10

Commit ID: 2ab83ac
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-20T22:52:41Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 2ab83ac
Duration 1:03:53
Result: ✅ SUCCEEDED
Error: N/A
Build Logs (available for 30 days)

foundationdb-ci · 2022-07-21T00:49:29Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 2ab83ac
Duration 3:00:37
Result: ❌ FAILED
Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
Build Logs (available for 30 days)

* fix heap-use-after-free caused by early noErrorsActors destroy * add comment * move keys out of StorageMetrics * format code * Java bindings for BG Purge (#6816) * Add support for returning whether a key-backed type range read has more results or not. * Use narrow includes in key backed types; remove some unnecessary return statements. * Fix snapshotFormatUnitTest infinite loop Patch addresses an issue where loop generating random buffer for the test might run in an infinite loop if KeySpace gets exhausted but the 'targetBuffer' bytes aren't generated. Description Testing * smaller function * Remove one more include and some extraneous return statements. Add a NullCodec that passes through the arguments unchanged. * Add a Tuple::makeTuple function to easily construct a tuple. Update Tuple to allow all types to be passed via .append() so they can be used with makeTuple. * Add the ability for StringRef.eat to return whether a separator was found. Add a serialize function and equality operators to ClusterConnectionString. Remove unused variable. * add unittest * Convert existing tuple usages to use Tuple::makeTuple() * resolve conflict upstream/main * Remove the ability to configure a tenant subspace. Rename the prefixes used for tenant metadata. * Fixing merge convergence bugs * Refactoring granule flush to retry properly on granule rollback * cleanup * Issue 7570: Check existance of container before creation attempt * cleanup * Use a constexpr check for deserialization (from code review) * Increase AllTags field length in TLogReady * Add a comment to name the fold expression syntax in makeTuple. This should make it easier to look up for those unfamiliar with the syntax. * Fix ASAN build (#7629) * Fix ASAN build Description -diff-2: Fix Mac build issues -diff-1: Address review comments Patch addresses the issue where ASAN build failed after introducing BlobGranule compression. Testing ASAN build * only do check after bootstraping test * Some minor changes from code review * solve review comments * function naming using intention rather than implementation details * update comments * Build fixes/improvements for sanitizers (#7657) * Don't build fdb c shim with ubsan This avoids duplicate symbols when linking. It doesn't really make sense to assemble files with -fsanitize=undefined anyway, since it won't insert instrumentation. * Consolidate boost_asan with boost_target * Log tlog initialization * Allow read range on null shard (#7654) * Fixed ShardedRocks unit test. * Removed `UNIT` from noSim/ShardedRocksDBTest.toml. Co-authored-by: He Liu <[email protected]> * Validate subrange reads in simulation (#7597) * Add extra validation to special key space reads in simulation * Fix bugs turned up by validating subrange reads * Change to validateSpecialSubrangeRead It is in general not safe to expect that a read from the special key space returns the same results if performed again, since the transaction may be being modified concurrently. * Add comment * Add comment * Add TraceEvent to the construction/destruction of DatabaseContext This is to figure out why huge databaseLogger related TraceEvents generated after 7.1 released. * Use key-backed types for tenants. Add a tenant state field that will be used in upcoming work. Some other tenant related refactoring. * Add CommitDebug event after Commit Proxy reporting committed version to master * fixup! Update code per comments * Ss shard management (#7340) * Storage server shard management with physical shards. * Cleanup. * Resolved comments. * Added `UnlimintedCommitBytes`. Co-authored-by: He Liu <[email protected]> * Proxy GlobalConfig reads through GRV proxies Clients should avoid reading system keys unless authorized. Under global config, each client reads from the system keyspace to check for new global config keys. This commit moves these reads to a server role (the GRV proxies) and sends the results back to GlobalConfig for an in-memory update. * Batch global config refresh requests * Perform migration automatically on proxy boot * Update fdbserver/GrvProxyServer.actor.cpp Co-authored-by: A.J. Beamon <[email protected]> * Update fdbclient/include/fdbclient/CommitProxyInterface.h Co-authored-by: A.J. Beamon <[email protected]> * Add migration timeout * Reduce global configuration system key reads from proxy Clients now poll the proxy for the latest global config for a specific version. The proxy now periodically requests the latest global configuration data and stores it in memory, enabling it to respond immediately to clients with the appropriate version. * Add delay to allow for global config sync time * Mess with timeout values * Simplify refresh condition * Fix Tuple error * Update fdbserver/GrvProxyServer.actor.cpp Co-authored-by: A.J. Beamon <[email protected]> * Update fdbserver/GrvProxyServer.actor.cpp Co-authored-by: A.J. Beamon <[email protected]> * Add comments to deleteTenantTransaction. Fetch the tenant ID from the first transaction in deleteTransaction to use on subsequent retries. * Don't pass non-pod to variadic function (#7668) fdbserver/storageserver.actor.cpp:654:24: error: cannot pass object of non-trivial type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char>>') through variadic function; call will abort at runtime [-Wnon-pod-varargs] Just use fmt instead * Disable guard pages for valgrind build. Closes #7610 (#7672) * fixup! Let clang accepts crc32_wrapper.c * Add timeout during Status generation Resolving hostname might be blocking. * Reduce a DNS lookup in Status generation * Update status json doc with fetch_storage_wiggler_stats_timeout error * Fix WinGDI name collision by defining macro NOGDI TenantState::ERROR collides with WinGDI's #define ERROR 0 * Move DD queue code over to using movement-reasons rather than priority (#7614) * Use enum variables to invoke Priority checking * add an explicit isDataMovementForReadBalancing function * Set up RelocateShard in terms of data movement reason instead of priority * Remove isMountainChopperPriority * Remove isDiskRebalancePriority * Fix formatting * Fix misnamed DataMovementReason::TEAM_HEALTHY Co-authored-by: Zhongxing Zhang <[email protected]> * Error in FetchKey GRV shouldn't fail storageserver * Add testing mechanism * ddsketch_utility: Add utility scripts for ddsketch (#7602) * Adds ddsketch_calc.py which implements a class for DDSketch related calculations * Adds ddsketch_conversion.py for quickly computing a bucket index to a value or vice-versa * Adds ddsketch_compare.py to compute how similar two ddsketch distributions are * Adds export_graph.py to graph the ddsketch distribution outputted from mako The arguments for ddsketch_conversion.py are: -b, --bucket: the bucket index that we need to calculate the value from (optional) -v, --value: the value that we need to calculate the bucket index from (optional) -e, --error_guarantee: the error guarantee for ddsketch (optional, default is 0.005) The arguments for ddsketch_compare.py are: --file1: Path to first ddsketch json --file2: Path to second ddsketch json --txn1: The transaction type for the first file --txn2: The transaction type for the second file --op: The operation name (ex: GRV, GET ...) The arguments for export_graph.py: --file: path to ddsketch distribution --txn, -t: Transaction type from file --title: title for graph (optional, otherwise "Title" is used) --savefig: Path to save the image plot (optional) --op: Which operation to plot Co-authored-by: Xiaoxi Wang <[email protected]> Co-authored-by: Josh Slocum <[email protected]> Co-authored-by: A.J. Beamon <[email protected]> Co-authored-by: Ata E Husain Bohra <[email protected]> Co-authored-by: Hari Bhaskaran <[email protected]> Co-authored-by: Trevor Clinkenbeard <[email protected]> Co-authored-by: Zhe Wu <[email protected]> Co-authored-by: Andrew Noyes <[email protected]> Co-authored-by: He Liu <[email protected]> Co-authored-by: He Liu <[email protected]> Co-authored-by: Xiaoge Su <[email protected]> Co-authored-by: Jingyu Zhou <[email protected]> Co-authored-by: Lukas Joswiak <[email protected]> Co-authored-by: Junhyun Shim <[email protected]> Co-authored-by: Bharadwaj V.R <[email protected]> Co-authored-by: Zhongxing Zhang <[email protected]> Co-authored-by: Markus Pilman <[email protected]> Co-authored-by: Kevin Hoxha <[email protected]>

liquid-helium force-pushed the ss-shard-management branch from ba0210a to 77a1870 Compare June 10, 2022 20:47

liquid-helium force-pushed the ss-shard-management branch from 9220cb9 to 445c533 Compare June 11, 2022 01:31

liquid-helium mentioned this pull request Jun 13, 2022

Shard based move #6981

Merged

5 tasks

Cleanup.

6cb416c

liquid-helium force-pushed the ss-shard-management branch from b19a849 to 6cb416c Compare July 18, 2022 17:25

liquid-helium requested review from jzhou77, neethuhaneesha and xy-54321 July 18, 2022 17:26

liquid-helium assigned xy-54321 Jul 18, 2022

liquid-helium marked this pull request as ready for review July 18, 2022 17:27

jzhou77 requested changes Jul 19, 2022

View reviewed changes

liquid-helium added 2 commits July 20, 2022 09:58

Resolved comments.

18c7c34

Added UnlimintedCommitBytes.

2ab83ac

liquid-helium requested review from jzhou77 and sfc-gh-abeamon July 20, 2022 21:49

jzhou77 approved these changes Jul 22, 2022

View reviewed changes

liquid-helium merged commit 7a8be25 into apple:main Jul 22, 2022

Ss shard management #7340

Ss shard management #7340

Uh oh!

Conversation

liquid-helium commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code-Reviewer Section

For Release-Branches

Uh oh!

fdb-windows-ci commented Jun 8, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jun 8, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 8, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 8, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 8, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jun 8, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jun 8, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Jun 10, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 10, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 10, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Uh oh!

fdb-windows-ci commented Jun 10, 2022

Doxense CI Report for Windows 10

Uh oh!

fdb-windows-ci commented Jun 10, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jun 10, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Jun 10, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jun 11, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Jun 11, 2022

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

Uh oh!

foundationdb-ci commented Jun 11, 2022

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 12, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Jun 15, 2022

Result of foundationdb-pr on Linux CentOS 7

liquid-helium commented Jun 8, 2022 •

edited

Loading