Skip to content

fix issues with build-images script #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ammolitor merged 1 commit into from
Dec 15, 2021
Merged

fix issues with build-images script #6145

ammolitor merged 1 commit into from
Dec 15, 2021

Conversation

@ammolitor
Copy link
Contributor

@ammolitor ammolitor commented Dec 14, 2021

copy packaging/docker to PROJECT_BINARY_DIR (undoing part of #5994),
fetch commit_sha from source_code_directory (don't assume we're in the source tree anymore),
allow custom tag (if a parameter is passed in as $1)
update README.md

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@ammolitor
copy packaging/docker to PROJECT_BINARY_DIR (undoing part of #5994),
89ffae9 
fetch commit_sha from source_code_directory (don't assume we're in the source tree anymore),
allow custom tag (if a parameter is passed in as $1)
update README.md
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Dec 14, 2021

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 89ffae9
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sbodagala
Copy link
Contributor

sbodagala commented Dec 14, 2021 •
edited
Loading

GitHub doesn't allow me to comment on lines 171-173 in "packaging/docker/build-images.sh", so posting this comment here.

Would you please move lines 171-173 to come after line 176 (my YCSB run picked up the images without any issue after I made that change)? Thanks!

liquid-helium
liquid-helium approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@liquid-helium liquid-helium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks Aaron!

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Dec 14, 2021

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 89ffae9
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@neethuhaneesha
Copy link
Contributor

neethuhaneesha commented Dec 14, 2021

Thanks!

@ammolitor
Copy link
Contributor Author

ammolitor commented Dec 15, 2021

GitHub doesn't allow me to comment on lines 171-173 in "packaging/docker/build-images.sh", so posting this comment here.

Would you please move lines 171-173 to come after line 176 (my YCSB run picked up the images without any issue after I made that change)? Thanks!

@sbodagala I verified that the -1 does not need to be at the end of the tag. given that, We will persist with the pattern of adding the -debug to the end of the tag as it is now.

@ammolitor ammolitor merged commit 95d33cb into master Dec 15, 2021
@ammolitor ammolitor deleted the build_images_fixes branch December 15, 2021 23:23
ammolitor added a commit that referenced this pull request Dec 16, 2021
@ammolitor
cherry-pick #6145
5aa64a5 
copy packaging/docker to PROJECT_BINARY_DIR (undoing part of #5994),
fetch commit_sha from source_code_directory (don't assume we're in the source tree anymore),
allow custom tag (if a parameter is passed in as $1)
update README.md
ammolitor added a commit that referenced this pull request Dec 16, 2021
@ammolitor
cherry-pick #6145
4d22f3d 
copy packaging/docker to PROJECT_BINARY_DIR (undoing part of #5994),
fetch commit_sha from source_code_directory (don't assume we're in the source tree anymore),
allow custom tag (if a parameter is passed in as $1)
update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethuhaneesha neethuhaneesha Awaiting requested review from neethuhaneesha

@sbodagala sbodagala Awaiting requested review from sbodagala

3 more reviewers

@halfprice halfprice halfprice approved these changes

@xumengpanda xumengpanda xumengpanda approved these changes

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ammolitor @foundationdb-ci @sbodagala @neethuhaneesha @halfprice @xumengpanda @liquid-helium