Skip to content

Conversation

@sfc-gh-anoyes
Copy link
Collaborator

Before this change, calling wait outside of an ACTOR would compile (!!)

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Before this change, calling `wait` outside of an ACTOR would compile (!!)
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 8b7e598
  • Result: FAILED
  • Build Logs (available for 30 days)

Copy link
Collaborator

@sfc-gh-fzhao sfc-gh-fzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 8b7e598
  • Result: FAILED
  • Build Logs (available for 30 days)

@sfc-gh-satherton
Copy link
Collaborator

@sfc-gh-anoyes This feels like an important enough bug-avoidance fix that we should cherry-pick it to 7.0.

@sfc-gh-anoyes sfc-gh-anoyes merged commit 1a50dea into apple:master Aug 26, 2021
sfc-gh-anoyes added a commit to sfc-gh-anoyes/foundationdb that referenced this pull request Aug 26, 2021
@sfc-gh-anoyes
Copy link
Collaborator Author

@sfc-gh-anoyes This feels like an important enough bug-avoidance fix that we should cherry-pick it to 7.0.

#5472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants