Skip to content

Conversation

@kakaiu
Copy link
Member

@kakaiu kakaiu commented Aug 24, 2021

Backporting #5370

Passed Joshua correctness-6.3.19 test: 20210824-183913-zhewang-631a84e28da76d58

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@kakaiu kakaiu requested review from RenxuanW and halfprice August 24, 2021 18:07
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 678ba1b
  • Result: FAILED
  • Build Logs (available for 7 days)

@kakaiu kakaiu closed this Aug 24, 2021
@kakaiu kakaiu reopened this Aug 24, 2021
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 678ba1b
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 678ba1b
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@kakaiu kakaiu closed this Aug 24, 2021
@kakaiu kakaiu reopened this Aug 24, 2021
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 678ba1b
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@kakaiu kakaiu merged commit e0140dd into apple:release-6.3 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants