Skip to content

Add version and timestamp to TimeKeeperCommit event. #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-abeamon merged 4 commits into from
Aug 18, 2021
Merged

Add version and timestamp to TimeKeeperCommit event. #5408

sfc-gh-abeamon merged 4 commits into from
Aug 18, 2021

Conversation

@xy-54321
Copy link
Contributor

@xy-54321 xy-54321 commented Aug 18, 2021

Example logs:

trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="15.409136" DateTime="2021-08-18T08:25:19Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="5f132f639a4ad17b" Version="407228" Timestamp="15" ThreadID="9788943724220871241" LogGroup="default" Roles="CC,CP,DD,GP,MS,RK,RV,SS,TL" />
trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="27.321964" DateTime="2021-08-18T08:25:19Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="0f02ea8bcbc12446" Version="6786252" Timestamp="27" ThreadID="9788943724220871241" LogGroup="default" Roles="BK,CC,CP,DD,GP,MS,RK,RV,SS,TL" />
trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="38.616454" DateTime="2021-08-18T08:25:20Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="574b788a0ab225f6" Version="22267114" Timestamp="38" ThreadID="9788943724220871241" LogGroup="default" Roles="BK,CC,CP,DD,GP,MS,RK,RV,SS,TL" />
trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="48.628305" DateTime="2021-08-18T08:25:20Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="af5c89b1f26a9736" Version="32467376" Timestamp="48" ThreadID="9788943724220871241" LogGroup="default" Roles="BK,CC,CP,DD,GP,MS,RK,RV,SS,TL" />
trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="58.639158" DateTime="2021-08-18T08:25:20Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="9dcf7a816494c1c4" Version="41770100" Timestamp="58" ThreadID="9788943724220871241" LogGroup="default" Roles="BK,CC,CP,DD,GP,MS,RK,RV,SS,TL" />
trace.0.0.0.0.0.1629275119.mlVgdn.0.1.xml:<Event Severity="10" Time="71.176920" DateTime="2021-08-18T08:25:20Z" Type="TimeKeeperCommit" Machine="2.0.1.1:1" ID="9ec7791689d114a7" Version="54436708" Timestamp="71" ThreadID="9788943724220871241" LogGroup="default" Roles="BK,CC,DD,GP,MS,RK,RV,SS,TL" />

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@xy-54321 xy-54321 requested a review from xumengpanda August 18, 2021 17:28
sfc-gh-abeamon
sfc-gh-abeamon reviewed Aug 18, 2021
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 977f8f4
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

sfc-gh-abeamon
sfc-gh-abeamon reviewed Aug 18, 2021
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 977f8f4
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

xumengpanda
xumengpanda previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@xumengpanda xumengpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after resolving AJ's comment

Can we include this in 6.3 branch as well?

@sfc-gh-tclinkenbeard do you want this in 7.0?

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: a5e2786
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

sfc-gh-abeamon
sfc-gh-abeamon reviewed Aug 18, 2021
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 4b8dadf
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

sfc-gh-abeamon
sfc-gh-abeamon reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@sfc-gh-abeamon sfc-gh-abeamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor nit comment, but otherwise this looks good to me.

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 7f0a09d
  • Result: FAILED
  • Build Logs (available for 7 days)

@sfc-gh-abeamon sfc-gh-abeamon merged commit 448ffe7 into apple:master Aug 18, 2021
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 7f0a09d
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 18, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 0afb63c
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request Aug 19, 2021
@sfc-gh-abeamon
[cherrypick] Add version and timestamp to TimeKeeperCommit event. (ap…
e7ee893 
…ple#5408)
@xy-54321 xy-54321 mentioned this pull request Aug 19, 2021
Merged
5 tasks
xy-54321 added a commit that referenced this pull request Aug 19, 2021
@xy-54321
[cherrypick] Add version and timestamp to TimeKeeperCommit event. (#5408
9f6219c 
) (#5415)
@xy-54321 xy-54321 mentioned this pull request Aug 19, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-abeamon sfc-gh-abeamon sfc-gh-abeamon approved these changes

@xumengpanda xumengpanda Awaiting requested review from xumengpanda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xy-54321 @foundationdb-ci @xumengpanda @sfc-gh-abeamon