Skip to content

[cherry-pick] Add histograms to CommitProxyServer. (#5299) #5369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xumengpanda merged 1 commit into from
Aug 27, 2021
Merged

[cherry-pick] Add histograms to CommitProxyServer. (#5299) #5369

xumengpanda merged 1 commit into from
Aug 27, 2021

Conversation

@xy-54321
Copy link
Contributor

@xy-54321 xy-54321 commented Aug 11, 2021

(cherry picked from commit 8609b45)

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 11, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 56f0171
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 11, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: a6c5128
  • Result: FAILED
  • Build Logs (available for 7 days)

@halfprice
Copy link
Contributor

halfprice commented Aug 11, 2021

Can you add joshua results here as well?

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 13, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 6a7c293
  • Result: FAILED
  • Build Logs (available for 7 days)

@xy-54321
Copy link
Contributor Author

xy-54321 commented Aug 14, 2021

Joshua result
20210813-001017-yaoxiao-5071d120bddcfb24 compressed=True data_size=24404240 duration=4436041 ended=101680 fail=1 fail_fast=10 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=1 day, 0:08:49 sanity=False started=101752 stopped=20210814-001906 submitted=20210813-001017 timeout=5400 username=yaoxiao

@halfprice
Copy link
Contributor

halfprice commented Aug 19, 2021

Hi @sfc-gh-mpilman , can you please take a look at this improvements as well, and see if there is any concerns for 7.0 branch?

@halfprice halfprice requested a review from xumengpanda August 20, 2021 16:29
@xumengpanda xumengpanda merged commit ecf8703 into apple:release-7.0 Aug 27, 2021
@xy-54321 xy-54321 deleted the r7.0 branch November 10, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-abeamon sfc-gh-abeamon Awaiting requested review from sfc-gh-abeamon

@sfc-gh-mpilman sfc-gh-mpilman Awaiting requested review from sfc-gh-mpilman

2 more reviewers

@halfprice halfprice halfprice approved these changes

@xumengpanda xumengpanda xumengpanda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@halfprice halfprice

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xy-54321 @foundationdb-ci @halfprice @xumengpanda