Skip to content

Conversation

@sfc-gh-jslocum
Copy link
Collaborator

As a result of larger scale performance and operational testing, I found these improvements:

  • duplicating other storage server metadata requests that go through load balance, to ensure equal load on SS/TSS
  • Not killing a TSS if an individual data move takes too long
  • Adding details to traces for, and fixing a bug in TSS recruitment that can cause the cluster to recruit fewer TSS than desired
  • Adding the count of wrong_shard_server errors to StorageMetrics, to be able to track any divergence in shards between the SS and TSS and the rate of tss reads not completed due to that divergence

Besides the real cluster testing, passed 250k correctness tests.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: b98b43f
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: b98b43f
  • Result: FAILED
  • Build Logs (available for 7 days)

@sfc-gh-jslocum
Copy link
Collaborator Author

CI Failure was due to something unrelated
/Users/ec2-user/foundationdb/bindings/c/test/unit/unit_tests_version_510.cpp:32:10: fatal error: 'doctest.h' file not found #include "doctest.h"

@sfc-gh-satherton sfc-gh-satherton merged commit c9b3726 into apple:release-7.0 Aug 13, 2021
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: b98b43f
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@sfc-gh-jslocum sfc-gh-jslocum deleted the tss_dd_improvements-7.0 branch July 27, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants