Skip to content

Add histograms to CommitProxyServer. #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xy-54321 merged 4 commits into from
Aug 5, 2021
Merged

Add histograms to CommitProxyServer. #5299

xy-54321 merged 4 commits into from
Aug 5, 2021

Conversation

@xy-54321
Copy link
Contributor

@xy-54321 xy-54321 commented Jul 28, 2021

Add metrics to track latencies in CommitProxyServer.

Test result will be added later.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 5766619
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 28, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 5766619
  • Result: FAILED
  • Build Logs (available for 7 days)

@xy-54321 xy-54321 force-pushed the proxy-server-histogram branch from 5766619 to 3dc0a7a Compare July 30, 2021 01:12
@xy-54321 xy-54321 force-pushed the proxy-server-histogram branch from 3dc0a7a to f243542 Compare July 30, 2021 01:13
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 3dc0a7a
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 3dc0a7a
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jul 30, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: f243542
  • Result: FAILED
  • Build Logs (available for 7 days)

halfprice
halfprice reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@halfprice halfprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you also run a chaos test and see if these histograms make sense?

sfc-gh-abeamon
sfc-gh-abeamon reviewed Jul 30, 2021
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 4, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 08cb42b
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 4, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 08cb42b
  • Result: FAILED
  • Build Logs (available for 7 days)

@apple apple deleted a comment from xy-54321 Aug 4, 2021
@xy-54321
Copy link
Contributor Author

xy-54321 commented Aug 4, 2021

Example logs

{"Severity":"10","Time":"1628118435.464770","DateTime":"2021-08-04T23:07:15Z","Type":"Histogram","ID":"0000000000000000","Group":"CommitProxy","Op":"ToResolver_003a3884a4e30fd275e61c18c2f513f9","Unit":"microseconds","LessThan0.256":"98","LessThan0.512":"15","LessThan1.024":"2","ThreadID":"3964936758328766672","Machine":"100.82.80.233:4501","LogGroup":"yx0803-primary-yx0803-single-sat-primary","Roles":"CP"}
{"Severity":"10","Time":"1628118435.464770","DateTime":"2021-08-04T23:07:15Z","Type":"Histogram","ID":"0000000000000000","Group":"CommitProxy","Op":"PostResolutionQueuing","Unit":"microseconds","LessThan0.002":"115","ThreadID":"3964936758328766672","Machine":"100.82.80.233:4501","LogGroup":"yx0803-primary-yx0803-single-sat-primary","Roles":"CP"}

halfprice
halfprice reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@halfprice halfprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yao! This looks good and I just have two small comments.

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: c9cf1b2
  • Result: FAILED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: c9cf1b2
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@xy-54321 xy-54321 requested a review from halfprice August 5, 2021 09:01
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: a9ada4d
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2021

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: a9ada4d
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@xy-54321 xy-54321 merged commit 8609b45 into apple:master Aug 5, 2021
@xy-54321 xy-54321 deleted the proxy-server-histogram branch August 5, 2021 23:29
xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Aug 11, 2021
@xy-54321
Add histograms to CommitProxyServer. (apple#5299)
e2b8912 
(cherry picked from commit 8609b45)
xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Aug 11, 2021
@xy-54321
Add histograms to CommitProxyServer. (apple#5299)
56f0171 
(cherry picked from commit 8609b45)
xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Aug 11, 2021
@xy-54321
Add histograms to CommitProxyServer. (apple#5299)
a6c5128 
(cherry picked from commit 8609b45)
xy-54321 added a commit to xy-54321/foundationdb that referenced this pull request Aug 13, 2021
@xy-54321
Add histograms to CommitProxyServer. (apple#5299)
6a7c293 
(cherry picked from commit 8609b45)
xumengpanda added a commit that referenced this pull request Aug 27, 2021
@xumengpanda
Merge pull request #5369 from yao-xiao-github/r7.0
ecf8703 
[cherry-pick] Add histograms to CommitProxyServer. (#5299)
xumengpanda added a commit that referenced this pull request Aug 27, 2021
@xumengpanda
Merge pull request #5367 from yao-xiao-github/r6.3
af13b18 
Cherry-pick (#5299) Add histograms to CommitProxyServer.
This was referenced Feb 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xumengpanda xumengpanda Awaiting requested review from xumengpanda

@sfc-gh-abeamon sfc-gh-abeamon Awaiting requested review from sfc-gh-abeamon

1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@halfprice halfprice

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xy-54321 @foundationdb-ci @halfprice @sfc-gh-abeamon