Skip to content

Conversation

@Daniel-B-Smith
Copy link

This has been tested both in simulation and with YCSB. It does not seem to impact write throughput, but it does seem to substantially improve read throughput.

The equivalent Dockerfile PR: FoundationDB/fdb-build-support#4

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 0c8ec28
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

@ammolitor ammolitor merged commit d5174b2 into apple:master Jul 29, 2021
@Daniel-B-Smith Daniel-B-Smith deleted the rocksdb-upgrade branch August 13, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants