Provide log version information to fdbdr status #5138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AWS CodeBuild CI Report
|
Co-authored-by: Trevor Clinkenbeard <[email protected]>
Contributor
AWS CodeBuild CI Report
|
Contributor
AWS CodeBuild CI Report
|
sfc-gh-tclinkenbeard
approved these changes
Jul 10, 2021
Collaborator
|
Can you also make this pull request against the |
Collaborator
Author
|
sfc-gh-jfu
approved these changes
Aug 13, 2021
sfc-gh-tclinkenbeard
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
I can make a fast consistent copy of a fdb cluster by stopping a DR site and copy all the files from all DR nodes to a new cluster nodes and detach this copy from the primary site.
I can perform a point-in-time recovery from this copy with fdbrestore start --incremental --begin_version XXXXXXX.
But there is no easy way to get a source db version for using with --begin_version option.
Findings
When dr agent runs it executes dr_copy_diff_logs tasks for copying version intervals of the mutation log to the DR database, When the task is executing, it has beginVersion: the version all changes before have been copied.
Proposal
Store beginVersion to the state subspace of system keyspace each time dr_copy_diff_logs executes
Read this version from the state subspace and return as result of fdbdr status
This pull request implements this proposal.
I already proposed this PR several monthes ago #4274 but I declided it because it couldn't be automatically rebased on top of 6.2. Now I'd like to propose it to 7.0.