Skip to content

Conversation

@sfc-gh-nwijetunga
Copy link
Collaborator

@sfc-gh-nwijetunga sfc-gh-nwijetunga commented Mar 22, 2021

Relates to: #4481

Currently the FastTriggeredWatches test in simulation fails because a watch takes longer to fire than the expected limit (12s). This PR increases the limit to 25s in hopes of reducing the flakiness of the test. We should consider moving this test out of simulation if this test continues to fail (for flaky reasons).

This has passed 50k Joshua runs

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-nwijetunga sfc-gh-nwijetunga changed the title Increase watch trigger time limit in simulation Increase watch trigger time limit in FastTriggeredWatches Mar 22, 2021
@sfc-gh-ljoswiak sfc-gh-ljoswiak merged commit 43c81e5 into apple:master Mar 23, 2021
@sfc-gh-nwijetunga sfc-gh-nwijetunga deleted the fix_fast_triggered_watches branch March 24, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants