Improve SimExternalConnection::read performance #4260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to the
SimExternalConnection::readimplementation.Style
git clang-format).Performance
std::vectorvsVectorRef).SlowTasktraces.Testing
If there are new parameters or knobs, different values are tested in simulation.ASSERT,ASSERT_WE_THINK, andTESTmacros are added in appropriate places.Unit tests were added for new algorithms and data structure that make sense to unit-testIf this is a bugfix: there is a test that can easily reproduce the bug.