FastRestore:Fix segmentation fault #3828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumengpanda
commented
Sep 30, 2020
| wait(recruitRestoreRoles(controllerWorker, self)); | ||
|
|
||
| self->addActor.send(updateHeartbeatTime(self)); | ||
| // self->addActor.send(updateHeartbeatTime(self)); |
Contributor
Author
There was a problem hiding this comment.
I chose to comment this out instead of removing it on purpose. This is supposed to track when a role is not responding quickly. I'm thinking about changing it to FDB's canonical way to do that. But it's not the focus of this PR.
dongxinEric
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fix for 6.3 branch of PR: #3827