Updated BindingTester #3804
Merged
Updated BindingTester #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support fo specify the number of ports from which to choose Swapped tabs for spaces to make Marcus happy 😃
sfc-gh-mpilman
approved these changes
Sep 23, 2020
Collaborator
sfc-gh-mpilman
left a comment
sfc-gh-mpilman
left a comment
There was a problem hiding this comment.
lgtm - I assume the functions themselves you didn't change semantically but just reformatted?
Contributor
Author
|
@mpilman Functions are basically the same. I did cherry-picked the commit from previous PR so that we can apply same changes to BindingTester on release branch. |
sfc-gh-kmakino
approved these changes
Sep 24, 2020
|
|
||
| else | ||
| "${BINDIR}/fdbserver" --knob_disable_posix_kernel_aio=1 -C "${FDBCONF}" -p "${FDBCLUSTERTEXT}" -L "${LOGDIR}" -d "${WORKDIR}/fdb/${$}" &> "${LOGDIR}/fdbserver.log" & | ||
| if [ "${?}" -ne 0 ] |
Collaborator
There was a problem hiding this comment.
This was a bit confusing to me, as I initially thought we would be checking the return code from fdbserver. After talking to @AlvinMooreSr, I realized that this is to check whether the process was successfully sent to the background. It would be nice if we had a one-line comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for specifying the FDB Cluster IP:Port combination
Added support for specifying the number of port from which to choose
Swtiched tabs for spaces to make Markus happy 😃