Skip to content

Fix data race described in #3749 #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajbeamon merged 2 commits into from
Sep 10, 2020
Merged

Fix data race described in #3749 #3750

ajbeamon merged 2 commits into from
Sep 10, 2020

Conversation

@sfc-gh-anoyes
Copy link
Collaborator

@sfc-gh-anoyes sfc-gh-anoyes commented Sep 5, 2020

No description provided.

@ajbeamon
Copy link
Contributor

ajbeamon commented Sep 8, 2020

I'm thinking a comment on the *Unsafe functions to indicate they should only be called while holding the mutex would be helpful too. What do you think?

@sfc-gh-anoyes
Copy link
Collaborator Author

sfc-gh-anoyes commented Sep 10, 2020

I'm thinking a comment on the *Unsafe functions to indicate they should only be called while holding the mutex would be helpful too. What do you think?

I added a comment, PTAL

@ajbeamon ajbeamon merged commit 0b8a4fc into apple:release-6.2 Sep 10, 2020
This was referenced Aug 2, 2021
Merged
Merged
@sfc-gh-abeamon sfc-gh-abeamon mentioned this pull request Aug 31, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajbeamon ajbeamon ajbeamon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfc-gh-anoyes @ajbeamon