Limit the amount of requests the proxy can queue up in memory #2812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
closes #2792 |
dongxinEric
reviewed
Mar 13, 2020
|
|
||
| bool operator == (const RequestStream<T>& rhs) const { return queue == rhs.queue; } | ||
| bool isEmpty() const { return !queue->isReady(); } | ||
| uint32_t size() const { return queue->size(); } |
Contributor
There was a problem hiding this comment.
Seems like this is added but not used?
Contributor
Author
There was a problem hiding this comment.
yeah, at one point I actually used it, but figured it was still probably a good function so I left it in
ajbeamon
reviewed
Mar 13, 2020
Contributor
ajbeamon
left a comment
ajbeamon
left a comment
There was a problem hiding this comment.
I guess the priority changes make us more vulnerable to CPU starvation at higher numbers of requests. We could probably minimize that by limiting the work done with each request at ReadSocket priority to only be the logic that lets it into the queue or rejects it.
Contributor
|
Rejected requests may be a useful metric for status. |
Contributor
Author
|
add errors to status |
…CPU with large numbers of outstanding requests
ajbeamon
reviewed
Mar 16, 2020
etschannen
commented
Mar 16, 2020
ajbeamon
reviewed
Mar 16, 2020
ajbeamon
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By receiving messages from the network at a high priority, we can track the number of requests outstanding, and if the proxy already has too many requests, send an error instead of responding to the message.
If a 6.2.18 or lower client sees this error from a GRV call, it will see database_locked or transaction_too_old errors instead of the proxy_memory_limit_exceeded error.