Skip to content

Add TLS Policy Failure count to ProcessMetrics and status json #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajbeamon merged 4 commits into from
Mar 16, 2020
Merged

Add TLS Policy Failure count to ProcessMetrics and status json #2811

ajbeamon merged 4 commits into from
Mar 16, 2020

Conversation

@alexmiller-apple
Copy link
Contributor

@alexmiller-apple alexmiller-apple commented Mar 13, 2020 •
edited
Loading

I didn't realize that status works via collecting traceevents from workers, so I'm trimming my plans down to just "hz", and the playbooks can link to a dashboard that aggregates TLSPolicyFailure trace events itself.

A trimmed status json from a failing process now looks like:

{
    "cluster" : {
        "processes" : {
            "bd91289b650802668e2217cc68f0463b" : {
                "address" : "127.0.0.1:5000:tls",
                "network" : {
                    "tls_policy_failures" : {
                        "hz" : 0.4
                    }
                }
            }
        }
    }
}

@alexmiller-apple
Add a ProcessMetrics.TLSPolicyFailures metric
75e2fff 
This reports the number of policy failures over the past 5s interval.
It also is step 1 towards getting this information into status json.
@alexmiller-apple
Add cluster.processes.id.network.tls_policy.hz to status.
d86a601 
This allows monitoring of TLS policy failures, but one has to go scrape
for TLSPolicyFailure trace events to figure out why they're happening.
@alexmiller-apple
Make policy failures be reported as per 1s and not over 5s.
04498cb
ajbeamon
ajbeamon reviewed Mar 13, 2020
View reviewed changes
@ajbeamon ajbeamon merged commit 5f4373c into apple:release-6.2 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajbeamon ajbeamon ajbeamon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ajbeamon ajbeamon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmiller-apple @ajbeamon