Add support for setting knobs in fdbcli #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 |
…rs. Apply this change to backup as well.
etschannen
reviewed
Mar 5, 2020
ajbeamon
commented
Mar 5, 2020
| else { | ||
| fprintf(stderr, "ERROR: Failed to set knob option '%s': %s\n", k->first.c_str(), e.what()); | ||
| TraceEvent(SevError, "FailedToSetKnob").detail("Knob", printable(k->first)).detail("Value", printable(k->second)).error(e); | ||
| throw; |
xumengpanda
reviewed
Mar 5, 2020
| Features | ||
| -------- | ||
|
|
||
| * Add support for setting knobs in fdbcli. `(PR #2773) <https://github.com/apple/foundationdb/pull/2773>`_. |
Contributor
There was a problem hiding this comment.
This seems still requires bouncing the process to use the new knob value.
Will it be clearer if we can add a line about whether or not bouncing the process is required?
Contributor
Author
There was a problem hiding this comment.
Maybe the release note is unclear, this allows you to set knobs for the fdbcli binary, not to use the cli to set knobs on other processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.