Fix issue with rebalancing data movement doing no work #2703
Conversation
…rds be present on the team and that the team have a minimum free ratio. This avoids scenarios where the team chosen when processing the request is later rejected by the requestor, causing rebalancing movements to get stuck.
fdbserver/DataDistribution.actor.h
Outdated
| bool wantsNewServers; | ||
| bool wantsTrueBest; | ||
| bool preferLowerUtilization; | ||
| bool requiresAssignedData; |
There was a problem hiding this comment.
I would appreciate if a comment can be added to explain requiresAssignedData .
Although I can figure this out by reading this PR, the future me or someone else will take more time to understand this.
There was a problem hiding this comment.
I'd rather this be clear from the name of the variable than add a comment. I could change it to teamMustHaveShards if that is more obvious, or I'm open to other suggestions.
There was a problem hiding this comment.
teamMustHaveShards is better and good to me.
|
I'm not sure if this PR wants to improve the visilility of DD or not. For example, we can count the times when |
|
Also in It seems to me a good place to add a trace so that we know when |
|
I decided to intentionally defer the work to add extra metrics to another PR. |
3 participants
Add new criteria to DD's
GetTeamRequestthat allow you to require shards be present on the team and that the team have a minimum free ratio. This can be used to avoid scenarios where the team chosen when processing the request is later rejected by the requestor. Hopefully resolves #1884.