Fix: Several boolean knobs could not be set at runtime #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CHINE_TEAM_REMOVER, TR_FLAG_REMOVE_MT_WITH_MOST_TEAMS, TR_FLAG_DISABLE_SERVER_TEAM_REMOVER, BUGGIFY_ALL_COORDINATION)
xumengpanda
approved these changes
Feb 11, 2020
Contributor
xumengpanda
left a comment
xumengpanda
left a comment
There was a problem hiding this comment.
The knob changes look good to me.
The CI fails because of the change in release note?
After CI passes, it is mergeable IMO.
Contributor
Author
|
Ah, I need the double backtick. Will fix tomorrow. |
ajbeamon
force-pushed
the
fix-unsettable-knobs
branch
from
928c80e to
be33bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following knobs were not settable at runtime:
Also adjust the whitespace of a few lines to match surrounding lines.