Fix: storage server version could fail to advance in response to empty commits #2617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessed if the peeked data contained a non-empty commit and ended with an empty commit.
Contributor
Author
|
This bug was introduced as part of this commit that was intended to fix a different bug: Our current thought, though, is that this change is not necessary to fix the problem turned up previously. Simulation testing to confirm is in progress. |
|
Any movement on this issue? I thiiiink this might be affecting my cluster, my p100 response times on transaction commits is ~3 seconds, so would love to try this out. |
Contributor
Author
|
This is basically all good to go, I just need to update the release notes to have a proper PR number. |
ajbeamon
commented
Feb 7, 2020
Add PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage server could fail to update its version to the latest processed if the peeked data contained a non-empty commit and ended with an empty commit.