Improve version pipelining on the proxy #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mount of work the proxy needs to do. This will help avoid getting a version from the master and then waiting a long time before committing it.
dongxinEric
reviewed
Jan 24, 2020
…t before getting a version from the master
Contributor
|
Build should be fixed now. @fdb-build, test cmake linux please. |
Contributor
|
@fdb-build, test cmake linux please. |
atn34
reviewed
Feb 4, 2020
ajbeamon
reviewed
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolvers and tLogs must process commits in the same order the master gives out versions. Therefore if a proxy gets a version from the master while it already has a ton of other batches it needs to submit to the transaction logs, it will create a situation where the resolvers and tLogs have to wait a long time for that version to be submitted before it can process requests from other proxies.
A proxy always works on the commit the is closest to completion, so there is no reason to get a version if we know the proxy already has a lot of CPU work it must do for other batches that are already in process.