Do not merge more than 100 shards together to avoid creating untrackable shards #2546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongxinEric
reviewed
Jan 15, 2020
| struct ShardMetrics { | ||
| StorageMetrics metrics; | ||
| double lastLowBandwidthStartTime; | ||
| int shardCount; |
Contributor
There was a problem hiding this comment.
Does shardCount need to be reset to 1 after merging?
Contributor
Author
There was a problem hiding this comment.
It will get reset to 1 when trackShardBytes detects that the merge has actually been carried out by the queue
dongxinEric
reviewed
Jan 15, 2020
| } | ||
| } | ||
|
|
||
| Future< StorageMetrics > Transaction::waitStorageMetrics( |
Contributor
There was a problem hiding this comment.
Just another moment when I wish c++ has some built-in Either<L, R> and case-matching support and... I guess I am wishing too much.
…hat the waitMetrics request can get the correct number of shards if two shards have been merged or split and the same storage server owns all the chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.