Fix slow task profiler crash #2515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it can lead to crashes if called at the wrong time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slow task profiler includes a call to
timer()to get the time that the backtrace was captured. This seems to be unsafe if the signal is raised in the middle of a call totime(), among possibly other things.This PR removes the call to
timer()in the signal handler and instead relies on the check thread to capture a time and propagate it to the signal handler using an atomic variable. In the event that atomic variables on the platform are not lock-free, this mechanism will not be used and instead the logs will not report the time that the backtrace was taken.Resolves #2364 (hopefully)