Fix internal error when client buggify fails successful transaction with commit_unknown_result #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uccessful transaction was failed with commit_unknown_result. Move some buggify errors into a try catch block so that the normal error handling path can run. Initialize startTime so that it's valid in the case of errors thrown early.
atn34
approved these changes
Dec 9, 2019
| not_committed(), | ||
| transaction_too_old(), | ||
| proxy_memory_limit_exceeded(), | ||
| commit_unknown_result()}); |
Collaborator
There was a problem hiding this comment.
After looking at this I wondered why database_locked isn't in here, but I guess a user may never intend to lock their database so may not want to test that case.
This was referenced Dec 9, 2019
Collaborator
|
Any reason not to merge this? Correctness testing will fail on release-6.2 until this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2424
Also:
Move some buggify errors into a try catch block so that the normal error handling path can run.
Initialize
startTimeso that it's valid in the case of errors thrown early.