Limit lifetime of timeout memory for transactions that have terminated #2353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajbeamon
changed the title
…in a situation where we get stuck in a loop due to floating point math.
atn34
reviewed
Nov 13, 2019
fdbclient/ReadYourWrites.actor.cpp
Outdated
|
|
||
| ACTOR Future<Void> timebomb(double endTime, Promise<Void> resetPromise) { | ||
| while(now() < endTime) { | ||
| wait( delayUntil( std::min(endTime, now() + CLIENT_KNOBS->TRANSACTION_TIMEOUT_DELAY_INTERVAL) ) ); |
Collaborator
There was a problem hiding this comment.
Out of curiosity, how exactly can this get stuck in a loop? I feel like delayUntil(endTime) completing should imply !(now() < endTime)
Contributor
Author
There was a problem hiding this comment.
There are various floating point operations that I gather could cause a delayUntil(20.0) to fire at something like 19.999999s. I agree that a better contract from delay would be nice, though.
Contributor
There was a problem hiding this comment.
This is also mainly a problem is simulation where delay(0) can actually happen instantly, so now()-endTime can round to 0, but now()<endTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2335