Fixed a slow task in the commit path on the proxy #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atn34
reviewed
Nov 13, 2019
| if(yieldBytes > SERVER_KNOBS->DESIRED_TOTAL_BYTES) { | ||
| yieldBytes = 0; | ||
| wait(yield()); | ||
| valueWriter = BinaryWriter(IncludeVersion()); |
Collaborator
There was a problem hiding this comment.
It would be nice if we can keep MutationListRef::blob_begin private. If we resolve #2146 then we can also re-use the serialization code for both the asynchronous and synchronous versions. I think this is ok for now.
Contributor
Author
There was a problem hiding this comment.
I will add a FIXME near both serialize functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.