Skip to content

Conversation

@etschannen
Copy link
Contributor

No description provided.

@etschannen etschannen requested a review from ajbeamon October 2, 2019 01:54
@xumengpanda
Copy link
Contributor

I'm confused at what this PR tries to achieve without diving into the code detail.

Does this PR solve the statement in the title "Backup and DR would not share mutations if started on different versions of FDB" or achieve that statement?

@ajbeamon
Copy link
Contributor

ajbeamon commented Oct 2, 2019

The title is describing the current situation, which is undesirable. This PR changes it so that the mutation log is shared correctly.

@ajbeamon ajbeamon self-assigned this Oct 2, 2019
@etschannen
Copy link
Contributor Author

It is possible backup will need be started and aborted multiple times to get backup and DR to share, because the destUIDLookup could actually have ranges from more than 2 versions of FDB (although it would only be saving the mutations for two of those lookup entries). When backup is started it will randomly join with one of the lookups for the same range, and if that happens to be the active DR then it will just work. If it is not the DR one, when you abort the backup it will remove the lookup key associated with the backup, so the next time backup starts it will join with a different lookup.

@etschannen etschannen merged commit 42b7acf into apple:release-6.2 Oct 17, 2019
@etschannen etschannen deleted the feature-share-mutations branch January 13, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants