Improve log router -> remote log bandwidth #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etschannen
reviewed
Sep 13, 2019
Contributor
etschannen
left a comment
etschannen
left a comment
There was a problem hiding this comment.
We should probably still update the 6.0 tlog with the same change
alexmiller-apple
force-pushed
the
faster-remote-dc
branch
from
7030d57 to
53bcf41
Compare
Contributor
Author
|
Turns out that logging the tag from #2099 breaks the build because the logged value has to be an int, so I've hacked around it. |
Contributor
Author
Are the correctness results to look for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements (and uses) parallel peeking for remote log router to log router peeks, and causes a merge cursor of parallel server peek cursors to top off their internal batch of requests when one cursor is exhausted.