CC caches the serialization of serverDBInfo, to avoid regenerating it many times #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void regenerating it many times
atn34
reviewed
Sep 11, 2019
flow/flow.h
Outdated
| }; | ||
|
|
||
| template<class V> | ||
| struct scalar_traits<CachedSerialization<V>> : std::true_type { |
Collaborator
There was a problem hiding this comment.
I think one problem is that the vtable for V won't get collected, since flatbuffers thinks it doesn't have a vtable
Collaborator
There was a problem hiding this comment.
I think that should be fine though, since the save path for ErrorOr<EnsureTable<CachedSerialization>> never gets called
ajbeamon
approved these changes
Sep 12, 2019
Contributor
ajbeamon
left a comment
ajbeamon
left a comment
There was a problem hiding this comment.
I've approved, pending the TODO item for ErrorOr. I assume you'll add release notes in a single commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still crashes when using the object serializer