Fix some validation logic when using the fdbcli fileconfigure command #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntain a valid object (e.g. if you omit the enclosing {} of your object).
Fix an internal error when configuring regions with some storage servers that don't have a datacenter set.
ajbeamon
commented
Aug 19, 2019
| auto ssi = decodeServerListValue( s.value ); | ||
| if ( !ssi.locality.dcId().present() || !newDcIds.count(ssi.locality.dcId().get()) ) { | ||
| missingDcIds.insert(ssi.locality.dcId().get()); | ||
| missingDcIds.insert(ssi.locality.dcId()); |
Contributor
Author
There was a problem hiding this comment.
@etschannen Can you verify that treating unset datacenter IDs as all the same is correct with respect to line 433 below?
Contributor
There was a problem hiding this comment.
It should be fine, it will trigger that error, which seems to be the intended behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an unknown_error when the file passed to fileconfigure doesn't contain a valid object (e.g. if you omit the enclosing {} of your object).
Fix an internal error when configuring regions with some storage servers that don't have a datacenter set.