Bug fix: fdbrestore commands other than "start" were using default cl… #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2019 13:19
…uster file argument handling (but without the -C flag) instead of using the --dest_cluster_file argument.
…cluster_file option even though it does not connect to a cluster.
Contributor
Author
|
This passed manual testing. |
ajbeamon
reviewed
Jul 30, 2019
Co-Authored-By: A.J. Beamon <[email protected]>
ajbeamon
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argument handling (but without the -C flag) instead of using the --dest_cluster_file argument.
Also fixes bug where trace file initialization (based on arguments) is not done for
fdbrestore startoperations.Also fixes bug where
fdbrestore start --dryrunwould still require a cluster file even though it would not be used.