Clients only connect to three proxies to reduce the number of network connections #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishesh
reviewed
Jul 29, 2019
fdbclient/MonitorLeader.actor.cpp
Outdated
| when( state ClientDBInfo ni = wait( brokenPromiseToNever( knownLeader->get().get().clientInterface.openDatabase.getReply( req ) ) ) ) { | ||
| TraceEvent("MonitorLeaderForProxiesGotClientInfo", knownLeader->get().get().clientInterface.id()).detail("Proxy0", ni.proxies.size() ? ni.proxies[0].id() : UID()).detail("ClientID", ni.id); | ||
| if(ni.proxies.size() > CLIENT_KNOBS->MAX_CLIENT_PROXY_CONNECTIONS) { | ||
| deterministicRandom()->randomShuffle(ni.proxies); |
Contributor
There was a problem hiding this comment.
Since we are mutating the list of proxies here, monitorMasterProxiesChanged will probably get triggered even when it shouldn't. Don't think it should matter much though, but that may also mean that ACTOR is probably unnecessary as it seems that Future is effectively clientDBInfo->onChange() as we'll shuffle this everytime which would make that ACTOR trigger onMasterProxyChanged() each time.
Contributor
|
@fdb-build, test macos please |
… and continue connecting to the wrong cluster
…ed to happen when speedUpSimulation is true
…atacenter to be considered dead
…ould have made all the clients talking to that coordinator connect to the same set of proxies optimized the code to avoid re-randomizing the same list of proxies
etschannen
commented
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.