-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Clients keep a persistent connection open with the coordinators #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
etschannen
merged 12 commits into
apple:master
from
etschannen:feature-coordinator-connection
Jul 27, 2019
Merged
Clients keep a persistent connection open with the coordinators #1902
etschannen
merged 12 commits into
apple:master
from
etschannen:feature-coordinator-connection
Jul 27, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates to the list of proxies Status still needs to be updated with client information with information from the coordinators
…formation needs to come from two different cluster controllers
ajbeamon
reviewed
Jul 26, 2019
fix: COORDINATOR_REGISTER_INTERVAL was not set fixed review comments
# Conflicts: # fdbclient/DatabaseContext.h # fdbclient/NativeAPI.actor.cpp # fdbclient/NativeAPI.actor.h # fdbserver/workloads/KillRegion.actor.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status has been changed to only give ~100 example client NetworkAddresses, instead of the entire list.
In addition, there is a list of clients for which the version of the software is maximum they support, to detect when clients cannot connect to a newer version.