Add cache_memory parameter to fdbserver #1889
Conversation
…K) page cache. Change the default slighty from 2000 MiB to 2GiB.
# Conflicts: # documentation/sphinx/source/release-notes.rst
| " Maximum amount of memory used for storage. The default\n" | ||
| " value is 1GiB. When specified without a unit, MB is\n" | ||
| " assumed.\n"); | ||
| printf(" --cache_memory SIZE\n" |
There was a problem hiding this comment.
So this help will only be displayed if you call fdbserver --dev-help - but not if you only pass --help. I assume the reason you want this to be a parameter is because users shouldn't be expected to touch knobs...
So I guess my confusion is: what exactly is the rule for putting this in --dev-help? Or should this be moved above this if-block? I have the same question for the --memory and --storage_memory options...
There was a problem hiding this comment.
I honestly don't really know the intended distinction between --dev-help and --help, but I decided not to take any stand on that here. I added this option where it is because it seemed conceptually similar to the other two memory options you listed.
There was a problem hiding this comment.
I guess this makes sense - although I think none of them should be under --dev-help - though I think this is a bit out of scope for this PR. I will make an issue.
3 participants
This parameter controls the size of the (4K) page cache. Also changed the default slighty from 2000 MiB to 2GiB.