Improve TransactionMetrics #1808
Conversation
…e connections and also a field to indicate whether the connection is internal. Convert some of the metrics to our Counter object instead of running totals.
ajbeamon
changed the title
|
@fdb-build test windows please |
fdbclient/DatabaseContext.h
Outdated
| int64_t transactionsProcessBehind; | ||
| int64_t transactionWaitsForFullRecovery; | ||
| UID dbId; | ||
| bool internal; |
There was a problem hiding this comment.
I feel it is better to add a comment behind internal to clarify: what request are considered as internal.
The comment can be:
// true if request is from FDB components, e.g., backup and restore.
It can save time when someone reads the code one year later.
|
Not sure why CTest fails. I'm throwing it to correctness test and let's see. |
|
Correctness fails sadly. |
xumengpanda
left a comment
xumengpanda
left a comment
There was a problem hiding this comment.
Correctness reports segmentation faults.
One failed test case is:
-r simulation --logsize 1024MiB -f foundationdb/tests/fast/LongStackWriteDuringRead.txt -b on -s 327764438
|
Darn, this is the result an editor issue that led to some changes from another branch being left over. Fix coming shortly. |
|
The problem has been fixed. It passes 20k random tests. |
3 participants
Add a random UID to TransactionMetrics in case a client opens multiple connections and also a field to indicate whether the connection is internal. Convert some of the metrics to our Counter object instead of running totals.