Add transaction size option #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
requested changes
Jun 20, 2019
Contributor
alecgrieser
left a comment
alecgrieser
left a comment
There was a problem hiding this comment.
This looks good overall, with just a few things. Were you able to verify this by trying to write a transaction that was larger than same custom option but still less than 10 MB and getting a failure?
Contributor
Author
|
I've addressed all comments and added a python test that verified the size limit is effective. The test catches a bug of not setting per transaction limit, which was fixed. |
alecgrieser
reviewed
Jun 21, 2019
Contributor
alecgrieser
left a comment
alecgrieser
left a comment
There was a problem hiding this comment.
Code looks good. I had two more comments on the docs that I left in the form of change suggestions.
Co-Authored-By: Alec Grieser <[email protected]>
Co-Authored-By: Alec Grieser <[email protected]>
alecgrieser
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows client to set transaction size as a database option, or as a transaction option.
This fixes #1681.